[sakai2-tcc] Code review process

classic Classic list List threaded Threaded
6 messages Options
Steve Swinsburg-3 Steve Swinsburg-3
Reply | Threaded
Open this post in threaded view
|

[sakai2-tcc] Code review process

Hi all,

Is the code review process moving forward? I've just been working on some god awful code in the CLE, which doesn't adhere to any sort of standard for formatting, whitespace, line breaks, or even modern practices in regards to the technology it is using, and its driving me up the wall.

Last we discussed this we were looking at Crucible or Fisheye possibly? Any movement there?

cheers,
Steve
_______________________________________________
sakai2-tcc mailing list
[hidden email]
http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
Neal Caidin-3 Neal Caidin-3
Reply | Threaded
Open this post in threaded view
|

Re: [sakai2-tcc] Code review process

Hi Steve,

Yes it is still moving forward. 

Because Apereo has two different vendors capable of providing hosting, I was asked by the Apereo Infrastructure group to get information from both. I'm meeting with the second vendor today, so hopefully we will have the complete information needed to make a decision within a couple of days. Then it is my hope that it won't take long (a day or three) to get the green light from the Infrastructure group and we can move forward.

Thanks for asking. I'll do a better job proactively keeping TCC posted.

-- Neal



Neal Caidin
Sakai CLE Community Coordinator
Skype: nealkdin
Twitter: ncaidin









On Aug 21, 2013, at 8:25 AM, Steve Swinsburg <[hidden email]> wrote:

Hi all,

Is the code review process moving forward? I've just been working on some god awful code in the CLE, which doesn't adhere to any sort of standard for formatting, whitespace, line breaks, or even modern practices in regards to the technology it is using, and its driving me up the wall.

Last we discussed this we were looking at Crucible or Fisheye possibly? Any movement there?

cheers,
Steve


_______________________________________________
sakai2-tcc mailing list
[hidden email]
http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
Steve Swinsburg-3 Steve Swinsburg-3
Reply | Threaded
Open this post in threaded view
|

Re: [sakai2-tcc] Code review process

Great, thanks Neal.

cheers,
Steve


On 21/08/2013, at 10:32 PM, Neal Caidin <[hidden email]> wrote:

Hi Steve,

Yes it is still moving forward. 

Because Apereo has two different vendors capable of providing hosting, I was asked by the Apereo Infrastructure group to get information from both. I'm meeting with the second vendor today, so hopefully we will have the complete information needed to make a decision within a couple of days. Then it is my hope that it won't take long (a day or three) to get the green light from the Infrastructure group and we can move forward.

Thanks for asking. I'll do a better job proactively keeping TCC posted.

-- Neal



Neal Caidin
Sakai CLE Community Coordinator
Skype: nealkdin
Twitter: ncaidin









On Aug 21, 2013, at 8:25 AM, Steve Swinsburg <[hidden email]> wrote:

Hi all,

Is the code review process moving forward? I've just been working on some god awful code in the CLE, which doesn't adhere to any sort of standard for formatting, whitespace, line breaks, or even modern practices in regards to the technology it is using, and its driving me up the wall.

Last we discussed this we were looking at Crucible or Fisheye possibly? Any movement there?

cheers,
Steve



_______________________________________________
sakai2-tcc mailing list
[hidden email]
http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
Berg, Alan Berg, Alan
Reply | Threaded
Open this post in threaded view
|

Re: [sakai2-tcc] Code review process

The formatting stuff can be done via PMD with a cut down set of rules and FindBugs also good at focusing attention. Therefore, the code review infrastructure should include some pointers to lines of code with warnings as a start to a proper review. I am hoping this is part of the hostingplan.


Regards,
          
Alan


Alan Berg

Innovation working group
On the use of ICT in Education & Research
University of Amsterdam


From: [hidden email] [[hidden email]] on behalf of Steve Swinsburg [[hidden email]]
Sent: 21 August 2013 14:48
To: Neal Caidin
Cc: [hidden email] 2
Subject: Re: [sakai2-tcc] Code review process

Great, thanks Neal.

cheers,
Steve


On 21/08/2013, at 10:32 PM, Neal Caidin <[hidden email]> wrote:

Hi Steve,

Yes it is still moving forward. 

Because Apereo has two different vendors capable of providing hosting, I was asked by the Apereo Infrastructure group to get information from both. I'm meeting with the second vendor today, so hopefully we will have the complete information needed to make a decision within a couple of days. Then it is my hope that it won't take long (a day or three) to get the green light from the Infrastructure group and we can move forward.

Thanks for asking. I'll do a better job proactively keeping TCC posted.

-- Neal



Neal Caidin
Sakai CLE Community Coordinator
Skype: nealkdin
Twitter: ncaidin









On Aug 21, 2013, at 8:25 AM, Steve Swinsburg <[hidden email]> wrote:

Hi all,

Is the code review process moving forward? I've just been working on some god awful code in the CLE, which doesn't adhere to any sort of standard for formatting, whitespace, line breaks, or even modern practices in regards to the technology it is using, and its driving me up the wall.

Last we discussed this we were looking at Crucible or Fisheye possibly? Any movement there?

cheers,
Steve



_______________________________________________
sakai2-tcc mailing list
[hidden email]
http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
Neal Caidin-3 Neal Caidin-3
Reply | Threaded
Open this post in threaded view
|

Re: [sakai2-tcc] Code review process

<base href="x-msg://25720/">I ain't got no idea. I'm not familiar with Crucible and Fisheye, but I presume that whatever features that they offer is what we will get? Like we don't have a choice about how those tools  work do we?

-- neal



Neal Caidin
Sakai CLE Community Coordinator
Skype: nealkdin
Twitter: ncaidin









On Aug 21, 2013, at 9:33 AM, "Berg, Alan" <[hidden email]> wrote:

The formatting stuff can be done via PMD with a cut down set of rules and FindBugs also good at focusing attention. Therefore, the code review infrastructure should include some pointers to lines of code with warnings as a start to a proper review. I am hoping this is part of the hostingplan.


Regards, 
           Alan


Alan Berg

Innovation working group
On the use of ICT in Education & Research
University of Amsterdam

From: [hidden email] [[hidden email]] on behalf of Steve Swinsburg [[hidden email]]
Sent: 21 August 2013 14:48
To: Neal Caidin
Cc: [hidden email] 2
Subject: Re: [sakai2-tcc] Code review process

Great, thanks Neal.

cheers,
Steve


On 21/08/2013, at 10:32 PM, Neal Caidin <[hidden email]> wrote:

Hi Steve,

Yes it is still moving forward. 

Because Apereo has two different vendors capable of providing hosting, I was asked by the Apereo Infrastructure group to get information from both. I'm meeting with the second vendor today, so hopefully we will have the complete information needed to make a decision within a couple of days. Then it is my hope that it won't take long (a day or three) to get the green light from the Infrastructure group and we can move forward.

Thanks for asking. I'll do a better job proactively keeping TCC posted.

-- Neal



Neal Caidin
Sakai CLE Community Coordinator
Skype: nealkdin
Twitter: ncaidin









On Aug 21, 2013, at 8:25 AM, Steve Swinsburg <[hidden email]> wrote:

Hi all,

Is the code review process moving forward? I've just been working on some god awful code in the CLE, which doesn't adhere to any sort of standard for formatting, whitespace, line breaks, or even modern practices in regards to the technology it is using, and its driving me up the wall. 

Last we discussed this we were looking at Crucible or Fisheye possibly? Any movement there?

cheers,
Steve


_______________________________________________
sakai2-tcc mailing list
[hidden email]
http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
Berg, Alan Berg, Alan
Reply | Threaded
Open this post in threaded view
|

Re: [sakai2-tcc] Code review process

Yes we do, if we have a choice in hosting and thus services.


Regards,
          
Alan


Alan Berg

Innovation working group
On the use of ICT in Education & Research
University of Amsterdam


From: Neal Caidin [[hidden email]] on behalf of Neal Caidin [[hidden email]]
Sent: 21 August 2013 15:35
To: Berg, Alan
Cc: Steve Swinsburg; [hidden email] 2
Subject: Re: [sakai2-tcc] Code review process

I ain't got no idea. I'm not familiar with Crucible and Fisheye, but I presume that whatever features that they offer is what we will get? Like we don't have a choice about how those tools  work do we?

-- neal



Neal Caidin
Sakai CLE Community Coordinator
Skype: nealkdin
Twitter: ncaidin









On Aug 21, 2013, at 9:33 AM, "Berg, Alan" <[hidden email]> wrote:

The formatting stuff can be done via PMD with a cut down set of rules and FindBugs also good at focusing attention. Therefore, the code review infrastructure should include some pointers to lines of code with warnings as a start to a proper review. I am hoping this is part of the hostingplan.


Regards, 
           Alan


Alan Berg

Innovation working group
On the use of ICT in Education & Research
University of Amsterdam

From: [hidden email] [[hidden email]] on behalf of Steve Swinsburg [[hidden email]]
Sent: 21 August 2013 14:48
To: Neal Caidin
Cc: [hidden email] 2
Subject: Re: [sakai2-tcc] Code review process

Great, thanks Neal.

cheers,
Steve


On 21/08/2013, at 10:32 PM, Neal Caidin <[hidden email]> wrote:

Hi Steve,

Yes it is still moving forward. 

Because Apereo has two different vendors capable of providing hosting, I was asked by the Apereo Infrastructure group to get information from both. I'm meeting with the second vendor today, so hopefully we will have the complete information needed to make a decision within a couple of days. Then it is my hope that it won't take long (a day or three) to get the green light from the Infrastructure group and we can move forward.

Thanks for asking. I'll do a better job proactively keeping TCC posted.

-- Neal



Neal Caidin
Sakai CLE Community Coordinator
Skype: nealkdin
Twitter: ncaidin









On Aug 21, 2013, at 8:25 AM, Steve Swinsburg <[hidden email]> wrote:

Hi all,

Is the code review process moving forward? I've just been working on some god awful code in the CLE, which doesn't adhere to any sort of standard for formatting, whitespace, line breaks, or even modern practices in regards to the technology it is using, and its driving me up the wall. 

Last we discussed this we were looking at Crucible or Fisheye possibly? Any movement there?

cheers,
Steve


_______________________________________________
sakai2-tcc mailing list
[hidden email]
http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc